agent-substrate / agent-substrate/substrate

Decouple and minimize atelet/ateom shared paths

未關閉
#1,604 1 則留言 0 個 reaction 已指派 1 人 已被 @HavenXia 認領 在 GitHub 檢視
area/api-machinery area/node kind/cleanup prio/P0
主要語言
Go
星號
1.8k
分支
316
平均合併
2 天 43 分鐘
30 天內合併 PR
287

描述

## Problem

Today ateom and atelet compute many per-actor directory paths from `actorUID` through the same `internal/ateompath` package.

Theses directories are only created and wiped by atelet, and the RPC request between atelet/ateom only carries `actorUID` instead of these directory paths so ateom has to recompute the paths on its end.

## Proposal

atelet owns the `actorUID` related paths and passes it in the RPCs. Can wrap them in a message (e.g. `ActorDirs`) and pass it to atelet RPCs.
```
root_dir
bundle_dir
runsc_state_dir
pid_file_dir
checkpoint_dir
restore_dir
durable_dir_volume_mounts_dir
system_info_volume_roots_dir
volumes_dir
```
These directories are read or writes in ateom as a whole. For per-item paths like pid file ateom can still compute from directory+name, both from the request instead of shared path logic.

We still need to keep some shared paths for atelet/ateom: per-ateom directory and socket, the netns name, the credential broker socket and the OLTP socket.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。