agent-substrate / agent-substrate/substrate

Decouple and minimize atelet/ateom shared paths

オープン
#1,604 コメント 1 件 リアクション 0 件 担当者 1 名 @HavenXia が担当を希望しています GitHub で見る
area/api-machinery area/node kind/cleanup prio/P0
主要言語
Go
スター
1.8k
フォーク
316
平均マージ
2日 43分
マージ済み PR(30日)
287

説明

## Problem

Today ateom and atelet compute many per-actor directory paths from `actorUID` through the same `internal/ateompath` package.

Theses directories are only created and wiped by atelet, and the RPC request between atelet/ateom only carries `actorUID` instead of these directory paths so ateom has to recompute the paths on its end.

## Proposal

atelet owns the `actorUID` related paths and passes it in the RPCs. Can wrap them in a message (e.g. `ActorDirs`) and pass it to atelet RPCs.
```
root_dir
bundle_dir
runsc_state_dir
pid_file_dir
checkpoint_dir
restore_dir
durable_dir_volume_mounts_dir
system_info_volume_roots_dir
volumes_dir
```
These directories are read or writes in ateom as a whole. For per-item paths like pid file ateom can still compute from directory+name, both from the request instead of shared path logic.

We still need to keep some shared paths for atelet/ateom: per-ateom directory and socket, the netns name, the credential broker socket and the OLTP socket.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。