agent-substrate / agent-substrate/substrate

Migrate container image repository from legacy GCR syntax to native Artifact Registry

未關閉
#1,180 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
area/dev-infra kind/cleanup
主要語言
Go
星號
1.8k
分支
316
平均合併
2 天 43 分鐘
30 天內合併 PR
287

描述

When deploying Substrate on GCP/GKE via ./hack/install-ate.sh --deploy-ate-system, the build and deployment tooling pushes images using legacy Container Registry (gcr.io) syntax configured in hack/ate-dev-env.sh.example and Makefile:

```
KO_DOCKER_REPO="gcr.io/${PROJECT_ID}/ate-images"
```
## Problem

Container Registry (gcr.io) is deprecated. When used with Google Cloud Artifact Registry's gcr.io compatibility redirect, repositories in Artifact Registry are single-level containers for packages. Path segments like ate-images/ are not subfolders, but instead get prepended into the package name (e.g. ate-images/ateapi-...), cluttering the repository.

Substrate should move to native Artifact Registry repository syntax

```${LOCATION}-docker.pkg.dev/${PROJECT_ID}/ate-images)```

## Suggested Solution
Update provisioning scripts to provision artifact registry, and update hack/ate-dev-env.sh.example and Makefile defaults to use native Artifact Registry:

```
-export KO_DOCKER_REPO="gcr.io/${PROJECT_ID}/ate-images"
+export KO_DOCKER_REPO="${GCE_REGION}-docker.pkg.dev/${PROJECT_ID}/ate-images"
```

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。