agent-substrate / agent-substrate/substrate

Migrate container image repository from legacy GCR syntax to native Artifact Registry

Aberta
#1,180 2 comentários 0 reações 0 responsáveis Ver no GitHub
area/dev-infra kind/cleanup
Linguagem predominante
Go
Estrelas
1.8k
Forks
316
Merge médio
2d 43min
PRs com merge (30d)
287

Descrição

When deploying Substrate on GCP/GKE via ./hack/install-ate.sh --deploy-ate-system, the build and deployment tooling pushes images using legacy Container Registry (gcr.io) syntax configured in hack/ate-dev-env.sh.example and Makefile:

```
KO_DOCKER_REPO="gcr.io/${PROJECT_ID}/ate-images"
```
## Problem

Container Registry (gcr.io) is deprecated. When used with Google Cloud Artifact Registry's gcr.io compatibility redirect, repositories in Artifact Registry are single-level containers for packages. Path segments like ate-images/ are not subfolders, but instead get prepended into the package name (e.g. ate-images/ateapi-...), cluttering the repository.

Substrate should move to native Artifact Registry repository syntax

```${LOCATION}-docker.pkg.dev/${PROJECT_ID}/ate-images)```

## Suggested Solution
Update provisioning scripts to provision artifact registry, and update hack/ate-dev-env.sh.example and Makefile defaults to use native Artifact Registry:

```
-export KO_DOCKER_REPO="gcr.io/${PROJECT_ID}/ate-images"
+export KO_DOCKER_REPO="${GCE_REGION}-docker.pkg.dev/${PROJECT_ID}/ate-images"
```

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.