adoptium / adoptium/github-release-scripts

releaseCheck is not using exact string matches, but picks up substrings

未关闭
#147 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Shell
星标
5
派生
21
平均合并
6 天 7 小时
30 天内合并 PR
3

描述

Split out from January 2024 retrospective -

_https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet._

https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet.
```
*** PERFORMING RELEASE CHECK TO SEE IF THERE ARE ANY UNEXPECTED PROBLEMS ***
Grabbing information from https://github.com/adoptium/temurin21-binaries/releases/tag/21.0.2+13
FILTER IS: 21.0.2%2B13
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
100 12464 0 12464 0 0 6000 0 --:--:-- 0:00:02 --:--:-- 6000
100 10.1M 0 10.1M 0 0 4756k 0 --:--:-- 0:00:02 --:--:-- 4756k
Linux on x64: OK!
Linux on aarch64: OK!
Linux on ppc64le: OK!
Linux on s390x: OK!
Linux on arm: Not published:
AIX on ppc64: OK!
Alpine on x64: OK!
Alpine on aarch64: OK!
Windows on x64: OK!
MacOS on x64: OK!
MacOS on aarch64: OK!
Source images: OK!
```

_Originally posted by @sxa in https://github.com/adoptium/temurin/issues/13#issuecomment-1908505870_

贡献指南

打开贡献指南

调研方向

阅读 releaseCheck.sh,跟踪它如何将 release 名称与报告中显示的 GitHub release 数据进行匹配。复现缺少 jdk- 前缀的名称被接受的情况,然后验证只有完全匹配的名称才能通过,并且异常 release 会被报告。

由索引模型根据 Issue 内容生成。

评估

技术栈
github, shell
领域
release
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。