adoptium / adoptium/github-release-scripts

releaseCheck is not using exact string matches, but picks up substrings

Aperta
#147 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Shell
Stelle
5
Fork
21
Merge medio
6g 7h
PR unite (30g)
3

Descrizione

Split out from January 2024 retrospective -

_https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet._

https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet.
```
*** PERFORMING RELEASE CHECK TO SEE IF THERE ARE ANY UNEXPECTED PROBLEMS ***
Grabbing information from https://github.com/adoptium/temurin21-binaries/releases/tag/21.0.2+13
FILTER IS: 21.0.2%2B13
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
100 12464 0 12464 0 0 6000 0 --:--:-- 0:00:02 --:--:-- 6000
100 10.1M 0 10.1M 0 0 4756k 0 --:--:-- 0:00:02 --:--:-- 4756k
Linux on x64: OK!
Linux on aarch64: OK!
Linux on ppc64le: OK!
Linux on s390x: OK!
Linux on arm: Not published:
AIX on ppc64: OK!
Alpine on x64: OK!
Alpine on aarch64: OK!
Windows on x64: OK!
MacOS on x64: OK!
MacOS on aarch64: OK!
Source images: OK!
```

_Originally posted by @sxa in https://github.com/adoptium/temurin/issues/13#issuecomment-1908505870_

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Read releaseCheck.sh and trace how it matches release names against the GitHub release data shown in the report. Reproduce the case where a name missing the jdk- prefix is accepted, then verify that only exact names pass and the abnormal release is reported.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github, shell
Ambito
release
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
38/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.