adoptium / adoptium/github-release-scripts

releaseCheck is not using exact string matches, but picks up substrings

Open
#147 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
5
Forks
21
Avg merge
6d 7h
Merged PRs (30d)
3

Description

Split out from January 2024 retrospective -

_https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet._

https://ci.adoptium.net/job/build-scripts/job/release/job/refactor_openjdk_release_tool/8089/ was published with a name missing the `jdk-` prefix, but the releaseCheck.sh didn't show it as everything abnormal - it seems to have found the right release - perhaps because it was a substring of the 'real' value - something to look at it in the releaseCheck.sh script as a potential buglet.
```
*** PERFORMING RELEASE CHECK TO SEE IF THERE ARE ANY UNEXPECTED PROBLEMS ***
Grabbing information from https://github.com/adoptium/temurin21-binaries/releases/tag/21.0.2+13
FILTER IS: 21.0.2%2B13
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
100 12464 0 12464 0 0 6000 0 --:--:-- 0:00:02 --:--:-- 6000
100 10.1M 0 10.1M 0 0 4756k 0 --:--:-- 0:00:02 --:--:-- 4756k
Linux on x64: OK!
Linux on aarch64: OK!
Linux on ppc64le: OK!
Linux on s390x: OK!
Linux on arm: Not published:
AIX on ppc64: OK!
Alpine on x64: OK!
Alpine on aarch64: OK!
Windows on x64: OK!
MacOS on x64: OK!
MacOS on aarch64: OK!
Source images: OK!
```

_Originally posted by @sxa in https://github.com/adoptium/temurin/issues/13#issuecomment-1908505870_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.