adopted-ember-addons / adopted-ember-addons/ember-metrics

Breaking changes in 1.4.x

Aperta
#380 2 commenti 5 reazioni 0 assegnatari Vedi su GitHub
Status: Help Wanted
Lingua principale
TypeScript
Stelle
367
Fork
158
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Just a heads-up that moving `utils/object-transform.js` and `utils/remove-from-dom.js` into a `-private` namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to override `trackEvent()` in an adapter and use `object-transforms#compact`.

Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!

Also, thanks for spending the time keeping this addon maintained and up-to-date!

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.