adopted-ember-addons / adopted-ember-addons/ember-metrics

Breaking changes in 1.4.x

Abierto
#380 2 comentarios 5 reacciones 0 asignados Ver en GitHub
Status: Help Wanted
Lenguaje dominante
TypeScript
Estrellas
367
Forks
158
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Just a heads-up that moving `utils/object-transform.js` and `utils/remove-from-dom.js` into a `-private` namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to override `trackEvent()` in an adapter and use `object-transforms#compact`.

Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!

Also, thanks for spending the time keeping this addon maintained and up-to-date!

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start by reviewing utils/object-transform.js and utils/remove-from-dom.js, including the move into the -private namespace and removal of their re-exports. No test or implementation target is named; the issue is done only after maintainers decide whether to address the reported downstream breakage or close it as awareness.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
api
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Necesita aclaración
Aptitud para principiantes
25/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.