adopted-ember-addons / adopted-ember-addons/ember-metrics

Breaking changes in 1.4.x

Offen
#380 2 Kommentare 5 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Status: Help Wanted
Vorherrschende Sprache
TypeScript
Sterne
367
Forks
158
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Just a heads-up that moving `utils/object-transform.js` and `utils/remove-from-dom.js` into a `-private` namespace and removing the re-exports should likely have been considered a breaking change since for all intents and purposes they were public and apps could reasonably be relying upon them. For example, if you wanted to override `trackEvent()` in an adapter and use `object-transforms#compact`.

Probably nothing to be done about it at this point, just opened this for awareness that there may be some broken downstream consumers. Feel free to close!

Also, thanks for spending the time keeping this addon maintained and up-to-date!

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.