adopted-ember-addons / adopted-ember-addons/ember-metrics

Allow consumer to disable tracking by default

Aperta
#264 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
367
Fork
158
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Ember Metrics allows to globally enabled and disable tracking through `enabled` property of the metrics service. This is helpful to comply with European privacy rules. It allows a site to disable tracking until the user explicitly confirmed to tracking. Sadly the value of that property is hardcoded as `true`. This forces consumers that want to disable tracking by default into two hacks:

1. Implement a custom metrics service in application namespace, which extends from the one provided by this addon and overrides `enabled` property.
2. Set `enabled` to `false` early in application boot e.g. using an instance initializer or `beforeModel` hook of application route.

It would be better if ember metrics allows to control the default value of that property through a configuration option.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.