adopted-ember-addons / adopted-ember-addons/ember-metrics

Allow consumer to disable tracking by default

Ouverte
#264 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
367
Forks
158
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Ember Metrics allows to globally enabled and disable tracking through `enabled` property of the metrics service. This is helpful to comply with European privacy rules. It allows a site to disable tracking until the user explicitly confirmed to tracking. Sadly the value of that property is hardcoded as `true`. This forces consumers that want to disable tracking by default into two hacks:

1. Implement a custom metrics service in application namespace, which extends from the one provided by this addon and overrides `enabled` property.
2. Set `enabled` to `false` early in application boot e.g. using an instance initializer or `beforeModel` hook of application route.

It would be better if ember metrics allows to control the default value of that property through a configuration option.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.