adopted-ember-addons / adopted-ember-addons/ember-metrics

Allow consumer to disable tracking by default

未關閉
#264 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
TypeScript
星號
367
分支
158
PR 合併指標
30 天內沒有已合併 PR

描述

Ember Metrics allows to globally enabled and disable tracking through `enabled` property of the metrics service. This is helpful to comply with European privacy rules. It allows a site to disable tracking until the user explicitly confirmed to tracking. Sadly the value of that property is hardcoded as `true`. This forces consumers that want to disable tracking by default into two hacks:

1. Implement a custom metrics service in application namespace, which extends from the one provided by this addon and overrides `enabled` property.
2. Set `enabled` to `false` early in application boot e.g. using an instance initializer or `beforeModel` hook of application route.

It would be better if ember metrics allows to control the default value of that property through a configuration option.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。