adobe / adobe/target-nodejs-sdk-samples

Possible depencensy issue

オープン
#55 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
19
フォーク
42
PR マージ指標
30日以内にマージされた PR はありません

説明

It seems that many dependencies are deprecated and some are no longer supported. Can this repo be updated?
```

npm update
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: target-nodejs-react-sample@1.0.0
npm error Found: webpack@5.95.0
npm error node_modules/webpack
npm error dev webpack@"^5.95.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer webpack@"^4.0.0" from uglifyjs-webpack-plugin@2.2.0
npm error node_modules/uglifyjs-webpack-plugin
npm error dev uglifyjs-webpack-plugin@"^2.2.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
```

Even after using `npm update --force` the following persists:

```
npm warn using --force Recommended protections disabled.
npm warn ERESOLVE overriding peer dependency
npm warn While resolving: uglifyjs-webpack-plugin@2.2.0
npm warn Found: webpack@5.95.0
npm warn node_modules/webpack
npm warn dev webpack@"^5.95.0" from the root project
npm warn 5 more (babel-loader, copy-webpack-plugin, file-loader, ...)
npm warn
npm warn Could not resolve dependency:
npm warn peer webpack@"^4.0.0" from uglifyjs-webpack-plugin@2.2.0
npm warn node_modules/uglifyjs-webpack-plugin
npm warn dev uglifyjs-webpack-plugin@"^2.2.0" from the root project
npm warn
npm warn Conflicting peer dependency: webpack@4.47.0
npm warn node_modules/webpack
npm warn peer webpack@"^4.0.0" from uglifyjs-webpack-plugin@2.2.0
npm warn node_modules/uglifyjs-webpack-plugin
npm warn dev uglifyjs-webpack-plugin@"^2.2.0" from the root project
npm warn deprecated fsevents@1.2.13: Upgrade to fsevents v2 to mitigate potential security issues
npm warn deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm warn deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm warn deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm warn deprecated figgy-pudding@3.5.2: This module is no longer supported.
npm warn deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm warn deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm warn deprecated move-concurrently@1.0.1: This package is no longer supported.
npm warn deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated fs-write-stream-atomic@1.0.10: This package is no longer supported.
npm warn deprecated babel-preset-es2015@6.24.1: 🙌 Thanks for using Babel: we recommend using babel-preset-env now: please read https://babeljs.io/env to update!
npm warn deprecated core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
```

```
npm run build && npm start

> target-nodejs-react-sample@1.0.0 build
> webpack --mode=production

[webpack-cli] Invalid configuration object. Webpack has been initialized using a configuration object that does not match the API schema.
- configuration.module.rules[0] has an unknown property 'query'. These properties are valid:
object { assert?, compiler?, dependency?, descriptionData?, enforce?, exclude?, generator?, include?, issuer?, issuerLayer?, layer?, loader?, mimetype?, oneOf?, options?, parser?, realResource?, resolve?, resource?, resourceFragment?, resourceQuery?, rules?, scheme?, sideEffects?, test?, type?, use?, with? }
-> A rule description with conditions and effects for modules.

```

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

まず `npm update` で依存関係の競合を再現し、次に `npm run build \u0026\u0026 npm start` を実行して webpack の設定エラーを確認します。webpack と uglifyjs-webpack-plugin に関係する依存関係のバージョン、および報告されている非推奨パッケージを確認します。インストールで force や legacy peer dependencies が不要になり、ビルドが正常に完了すれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript, webpack
領域
build-system
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。