adobe / adobe/aio-cli-plugin-cloudmanager

Update of CM pipeline settings doesn't validate branch/tag existence

オープン
#492 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement help wanted
主要言語
JavaScript
スター
50
フォーク
36
PR マージ指標
30日以内にマージされた PR はありません

説明

**Expected Behavior**

User input (branch/tag/repositoryId) must be validated upon update of CM pipeline settings.

**Actual Behavior**

`aio cloudmanager:pipeline:update` ends successfully for not existing branches/tags.

**Reproduction Scenario, Platform, and Version**

```
$ aio -v
@adobe/aio-cli/8.1.0 darwin-x64 node-v14.17.6
```

**Steps to Reproduce**

```
$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --branch=this-branch-does-not-exist
updating pipeline... updated pipeline ID

$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --tag=not-existing-tag
updating pipeline... updated pipeline ID
```

Once above is set you can start the pipeline, but it's gonna fail immediately at validation stage with the following message:

> Failed: Invalid pipeline: . Reason=Branch=this-branch-does-not-exist not found in repository (Finished: September 22, 2021 11:14:23 AM GMT+2)

In contrast repository ID is being validated, so I assume that it may require some backend API changes:

```
$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --repositoryId=123456
updating pipeline... failed
› Error: [CloudManagerSDK:ERROR_UPDATE_PIPELINE] Cannot update pipeline: https://cloudmanager.adobe.io/api/program/PROGRAMID/pipeline/PIPELINEID (400 Bad Request) - Validation
› Error(s): Referenced repository not found in application or is not ready for use: 123456
› Code: ERROR_UPDATE_PIPELINE
```

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Start with the `aio cloudmanager:pipeline:update` command and reproduce the branch and tag cases described in the issue, comparing them with the repositoryId validation result. Done means updates using nonexistent branches or tags are rejected during the update, rather than succeeding and failing only when the pipeline starts.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript
領域
cli, cloud
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。