addyosmani / addyosmani/critical

Resource Utilization

Aperta
#589 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
10.3k
Fork
390
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Dear maintainers,

I would like to clarify, maybe, a simple question. For context, we have a container dedicated on running critical to extract css from pages running on a k8s pod behind a HTTP server, I would like to know if every time that a requests arrives does it spin up another window or use the same window open, using the base implementation of critical? We've been seen that the container is consuming all the available resources, the scenario is for tens of thousand requests per minute. Is there any docs on how critical manages penthouse therefore manages puppeteer in headless mode ?

```ts
async function getBrowser() {
return puppeteer.launch({
args: ['--no-sandbox', '--disable-dev-shm-usage'],
executablePath: '/usr/bin/chromium',
headless: true,
})
}
```

```ts
const { css } = await critical.generate({
html,
width,
height,
request: {
method: 'get',
},
penthouse: {
puppeteer: {
getBrowser,
},
blockJSRequests: false,
},
...
```

Best,

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.