addyosmani / addyosmani/critical

Resource Utilization

Abierto
#589 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
10.3k
Forks
390
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Dear maintainers,

I would like to clarify, maybe, a simple question. For context, we have a container dedicated on running critical to extract css from pages running on a k8s pod behind a HTTP server, I would like to know if every time that a requests arrives does it spin up another window or use the same window open, using the base implementation of critical? We've been seen that the container is consuming all the available resources, the scenario is for tens of thousand requests per minute. Is there any docs on how critical manages penthouse therefore manages puppeteer in headless mode ?

```ts
async function getBrowser() {
return puppeteer.launch({
args: ['--no-sandbox', '--disable-dev-shm-usage'],
executablePath: '/usr/bin/chromium',
headless: true,
})
}
```

```ts
const { css } = await critical.generate({
html,
width,
height,
request: {
method: 'get',
},
penthouse: {
puppeteer: {
getBrowser,
},
blockJSRequests: false,
},
...
```

Best,

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.