addyosmani / addyosmani/critical
Mismatch in computed styles after critical
- Ngôn ngữ chính
- JavaScript
- Star
- 10.3k
- Fork
- 390
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
After using critical, there's a mismatch in the computed styles:

[Without critical](https://pwapp-24858.web.app/dash), and [with critical](https://pwapp-24858.web.app/critical)
If you patiently inspect the styles, you see there's a mismatch in the computed styles, especially `border-radius`
I tried to [fix the issue](https://github.com/espoal/pwapp/blob/main/libs/critical/index.mjs) by using `forceInclude` to no avail. It seems that when splitting the styles, the `uncritical.css` gets precedence over the inlined styles.
Btw: Amazing project. I took a commercial dashboard, whose load time was around 10 second, and I brought it to 2 seconds with a lot of work (ssr, lazy load, minification...) and then to 0.8 seconds with critical. This npm had by far the most impact, with the least amount of work, it should be advertised everywhere.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.