addyosmani / addyosmani/critical
Mismatch in computed styles after critical
- Lenguaje dominante
- JavaScript
- Estrellas
- 10.3k
- Forks
- 390
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
After using critical, there's a mismatch in the computed styles:

[Without critical](https://pwapp-24858.web.app/dash), and [with critical](https://pwapp-24858.web.app/critical)
If you patiently inspect the styles, you see there's a mismatch in the computed styles, especially `border-radius`
I tried to [fix the issue](https://github.com/espoal/pwapp/blob/main/libs/critical/index.mjs) by using `forceInclude` to no avail. It seems that when splitting the styles, the `uncritical.css` gets precedence over the inlined styles.
Btw: Amazing project. I took a commercial dashboard, whose load time was around 10 second, and I brought it to 2 seconds with a lot of work (ssr, lazy load, minification...) and then to 0.8 seconds with critical. This npm had by far the most impact, with the least amount of work, it should be advertised everywhere.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.