addyosmani / addyosmani/agent-skills

`/review` slash command collides with Claude Code's bundled `/review` — intentional or worth namespacing?

Đang mở
#95 4 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
JavaScript
Star
94.1k
Fork
10k
Merge trung bình
3 ngày 15 giờ
Pull request đã merge (30 ngày)
23

Mô tả

## Summary

Installing this plugin into Claude Code registers a `/review` slash command that
shadows Claude Code's **built-in** `/review` (and conceptually overlaps with the
built-in `/security-review`). I couldn't find any mention of this in the README
or existing issues, so I'd like to confirm whether the collision is intentional
before choosing an install strategy.

## Evidence

Claude Code ships `/review`, `/security-review`, and `/init` as bundled skills
invocable via the Skill tool — documented at:
- https://code.claude.com/docs/en/commands.md
- https://code.claude.com/docs/en/skills.md
> "A few built-in commands are also available through the Skill tool,
> including `/init`, `/review`, and `/security-review`."

This repo's README lists 7 slash commands, one of which is literally `/review`.
Because Claude Code resolves project → user → plugin → built-in, the
plugin-registered `/review` wins and the built-in becomes unreachable.

Interestingly, the **skill slugs** in this repo (`code-review-and-quality`,
`code-simplification`, `security-and-hardening`, …) are all long-form and do
*not* collide with any Claude Code built-in skill — which reads as deliberate
namespacing. Only the slash command layer collides.

## Questions

1. Is the `/review` name intentional (i.e., you want to replace the built-in),
or was the built-in's existence not considered?
2. If intentional, would you be open to documenting this in the README so
users can make an informed choice?
3. If unintentional, would you accept a PR that renames the slash commands to
a namespaced form (e.g., `/as-review`, `/agent-review`, or `/lifecycle-review`)
while keeping the underlying skill slugs unchanged?

## Workaround I'm considering locally

Keeping the plugin installed but overriding `/review` back to the built-in via
a project-level `.claude/commands/review.md` that just invokes the
`code-review-and-quality` skill on demand, so the built-in stays reachable by
default. Happy to share if useful.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.