acm-uiuc / acm-uiuc/core

Fix Core tagging/release workflow

Aperta
#613 0 commenti 0 reazioni 1 assegnatario Rivendicata da @ashleyyli Vedi su GitHub
bug github_actions
Lingua principale
TypeScript
Stelle
5
Fork
0
Merge medio
3h 58m
PR unite (30g)
10

Descrizione

Currently, when the release checker checks for a new package.json version, it immediately creates the tag and the other pipeline takes over to run the release: https://github.com/acm-uiuc/core/blob/main/.github/workflows/release.yml

However, if the released code fails to build, then we have a tag created with broken code. We should instead first build/unit test the code, then create the tag, and then run the release stuff. This most likely requires using multiple stages in the github actions, etc.

Ideally, we also modify the Github action so that if the previous commit failed to deploy for the tag, then it will run it, even if the version didn't change.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start with .github/workflows/release.yml and the workflow or script that checks package.json versions and creates tags. Trace where the tag is currently created versus where build and unit tests run. Done means the workflow tests/builds before tagging and can rerun a failed deploy for an existing tag even when the version has not changed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github-actions, node.js, typescript
Ambito
build-system, ci-cd, release
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
32/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.