acm-uiuc / acm-uiuc/core

Fix Core tagging/release workflow

Offen
#613 0 Kommentare 0 Reaktionen 1 zugewiesene Person Beansprucht von @ashleyyli Auf GitHub ansehen
bug github_actions
Vorherrschende Sprache
TypeScript
Sterne
5
Forks
0
Ø Merge
3 Std. 58 Min.
Gemergte PRs (30 T.)
10

Beschreibung

Currently, when the release checker checks for a new package.json version, it immediately creates the tag and the other pipeline takes over to run the release: https://github.com/acm-uiuc/core/blob/main/.github/workflows/release.yml

However, if the released code fails to build, then we have a tag created with broken code. We should instead first build/unit test the code, then create the tag, and then run the release stuff. This most likely requires using multiple stages in the github actions, etc.

Ideally, we also modify the Github action so that if the previous commit failed to deploy for the tag, then it will run it, even if the version didn't change.

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Rechercherichtung

Start with .github/workflows/release.yml and the workflow or script that checks package.json versions and creates tags. Trace where the tag is currently created versus where build and unit tests run. Done means the workflow tests/builds before tagging and can rerun a failed deploy for an existing tag even when the version has not changed.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github-actions, node.js, typescript
Bereich
build-system, ci-cd, release
Issue-Typ
Bug
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
32/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.