acm-uiuc / acm-uiuc/core

Allow editing room requests in certain states

Aperta
#597 0 commenti 0 reazioni 1 assegnatario Rivendicata da @MeghP89 Vedi su GitHub
enhancement
Lingua principale
TypeScript
Stelle
5
Fork
0
Merge medio
3h 58m
PR unite (30g)
10

Descrizione

Currently, users cannot edit a room request after it has been submitted. We should allow both the user which created the request, or `ROOM_REQUEST_ADMIN` app role, to modify the room request only when it is the following states:

- CREATED
- MORE_INFORMATION_NEEDED
- REJECTED_BY_ACM
- REJECTED_BY_UIUC

This change requires modification to both the UI and API to allow these changes and enforce the constraints.

These are "recoverable" states (and should be added to types file so it can be used in the UI and API). We can modify the `verifyRoomRequestAccess` function to add `isEditing` parameter to check these conditions.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.