acm-uiuc / acm-uiuc/core

Allow editing room requests in certain states

Abierto
#597 0 comentarios 0 reacciones 1 asignado Reclamado por @MeghP89 Ver en GitHub
enhancement
Lenguaje dominante
TypeScript
Estrellas
5
Forks
0
Merge medio
3 h 58 min
PR fusionados (30 d)
10

Descripción

Currently, users cannot edit a room request after it has been submitted. We should allow both the user which created the request, or `ROOM_REQUEST_ADMIN` app role, to modify the room request only when it is the following states:

- CREATED
- MORE_INFORMATION_NEEDED
- REJECTED_BY_ACM
- REJECTED_BY_UIUC

This change requires modification to both the UI and API to allow these changes and enforce the constraints.

These are "recoverable" states (and should be added to types file so it can be used in the UI and API). We can modify the `verifyRoomRequestAccess` function to add `isEditing` parameter to check these conditions.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.