acl-org / acl-org/acl-anthology

buggy sitemap.xml generation

未关闭 适合新手
#9,241 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug python-library
主要语言
Python
星标
797
派生
408
平均合并
3 天 19 小时
30 天内合并 PR
36

描述

#9182 and #9240 attempted to fix this, but it seems part of the problem is that the default ingestion date for volumes (when no `ingest-date` attribute in XML) is 1900-01-01. And this is inherited for papers within the volume if not otherwise specified.

https://github.com/acl-org/acl-anthology/blob/7d1e9e40ba8a49b2827af97f1c7f5f7b5f3c4a1a/python/acl_anthology/constants.py#L30-L31

`` entries are filled in with the ingestion date. Google considers dates in 1900 to be invalid. We should probably just omit `` if we don't have a recorded ingestion date.

@mbollmann is there a reason not to use None as the default, for example?

贡献指南

这个仓库没有索引到贡献指南

调研方向

Open python/acl_anthology/constants.py at the linked lines to verify the default ingest date value. Then trace where sitemap.xml lastmod is generated from that value and adjust logic so items without a recorded ingestion date omit lastmod instead of inheriting 1900-01-01. Run the sitemap-generation path or related tests and inspect generated sitemap.xml so valid dates remain and no 1900 dates are emitted.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
web-dev
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
冷清
描述清晰度
基本清楚
新手友好度
70/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。