acl-org / acl-org/acl-anthology

buggy sitemap.xml generation

Open Beginner friendly
#9,241 5 comments 0 reactions 0 assignees View on GitHub
bug python-library
Dominant language
Python
Stars
797
Forks
408
Avg merge
3d 19h
Merged PRs (30d)
36

Description

#9182 and #9240 attempted to fix this, but it seems part of the problem is that the default ingestion date for volumes (when no `ingest-date` attribute in XML) is 1900-01-01. And this is inherited for papers within the volume if not otherwise specified.

https://github.com/acl-org/acl-anthology/blob/7d1e9e40ba8a49b2827af97f1c7f5f7b5f3c4a1a/python/acl_anthology/constants.py#L30-L31

`` entries are filled in with the ingestion date. Google considers dates in 1900 to be invalid. We should probably just omit `` if we don't have a recorded ingestion date.

@mbollmann is there a reason not to use None as the default, for example?

Contributor guide

No contributing guide indexed for this repository

Research direction

Open python/acl_anthology/constants.py at the linked lines to verify the default ingest date value. Then trace where sitemap.xml lastmod is generated from that value and adjust logic so items without a recorded ingestion date omit lastmod instead of inheriting 1900-01-01. Run the sitemap-generation path or related tests and inspect generated sitemap.xml so valid dates remain and no 1900 dates are emitted.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.