acl-org / acl-org/acl-anthology

buggy sitemap.xml generation

Open
#9,241 5 comments 0 reactions 0 assignees View on GitHub
bug python-library
Dominant language
Python
Stars
796
Forks
408
Avg merge
3d 13h
Merged PRs (30d)
34

Description

#9182 and #9240 attempted to fix this, but it seems part of the problem is that the default ingestion date for volumes (when no `ingest-date` attribute in XML) is 1900-01-01. And this is inherited for papers within the volume if not otherwise specified.

https://github.com/acl-org/acl-anthology/blob/7d1e9e40ba8a49b2827af97f1c7f5f7b5f3c4a1a/python/acl_anthology/constants.py#L30-L31

`` entries are filled in with the ingestion date. Google considers dates in 1900 to be invalid. We should probably just omit `` if we don't have a recorded ingestion date.

@mbollmann is there a reason not to use None as the default, for example?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.