acacode / acacode/swagger-typescript-api

Bug in enum keys generation: underscores should not be removed if enum value contains digits. E. g. for value `AMAZON_S3` generated key `AMAZONS3` is wrong

未關閉
#988 1 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
bug
主要語言
TypeScript
星號
4.1k
分支
436
PR 合併指標
30 天內沒有已合併 PR

描述

For example, this enum definition

```json
[
//...
"foo.bar.StorageType": {
"description": "this enum contains available object storages",
"type": "string",
"default": "ORACLE_OBJECT_STORAGE",
"enum": [
"ORACLE_OBJECT_STORAGE",
"AMAZON_S3",
]
},
//...
]
```

is transformed into

```typescript
export enum FooBarStorageTypeDto {
ORACLE_OBJECT_STORAGE = "ORACLE_OBJECT_STORAGE",
AMAZONS3 = "AMAZON_S3",
}
```

Please notice `AMAZONS3`. The key should be `AMAZON_S3`, but the underscore is being removed.

It happens because of [this regexp](https://github.com/acacode/swagger-typescript-api/blob/main/src/type-name-formatter.ts#L35), `AMAZON_S3` doesn't match it. I guess the regexp should be changed in order to support names with digits.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。