acacode / acacode/swagger-typescript-api

Bug in enum keys generation: underscores should not be removed if enum value contains digits. E. g. for value `AMAZON_S3` generated key `AMAZONS3` is wrong

Abierto
#988 1 comentario 1 reacción 0 asignados Ver en GitHub
bug
Lenguaje dominante
TypeScript
Estrellas
4.1k
Forks
436
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

For example, this enum definition

```json
[
//...
"foo.bar.StorageType": {
"description": "this enum contains available object storages",
"type": "string",
"default": "ORACLE_OBJECT_STORAGE",
"enum": [
"ORACLE_OBJECT_STORAGE",
"AMAZON_S3",
]
},
//...
]
```

is transformed into

```typescript
export enum FooBarStorageTypeDto {
ORACLE_OBJECT_STORAGE = "ORACLE_OBJECT_STORAGE",
AMAZONS3 = "AMAZON_S3",
}
```

Please notice `AMAZONS3`. The key should be `AMAZON_S3`, but the underscore is being removed.

It happens because of [this regexp](https://github.com/acacode/swagger-typescript-api/blob/main/src/type-name-formatter.ts#L35), `AMAZON_S3` doesn't match it. I guess the regexp should be changed in order to support names with digits.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.