acacode / acacode/swagger-typescript-api
fetch http client return type is wrong when `unwrapResponseData` is false
未關閉
- 主要語言
- TypeScript
- 星號
- 4.1k
- 分支
- 436
- PR 合併指標
- 30 天內沒有已合併 PR
描述
Looking at this code: https://github.com/acacode/swagger-typescript-api/blob/master/templates/base/http-clients/fetch-http-client.ejs#L159-L224
The return type should be `Promise>` when `unwrapResponseData` is false. If the request is successful and no error is thrown, the error property will always be null.
In fact, it seems like there is no point in having the generic `E` as a part of custom fetch because there is no guarantee that it will be the type given this line https://github.com/acacode/swagger-typescript-api/blob/master/templates/base/http-clients/fetch-http-client.ejs#L206.
貢獻指南
這個儲存庫沒有索引到貢獻指南
評估
這個 Issue 還沒有評估資料。