acacode / acacode/swagger-typescript-api

fetch http client return type is wrong when `unwrapResponseData` is false

Aperta
#513 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
4.1k
Fork
436
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Looking at this code: https://github.com/acacode/swagger-typescript-api/blob/master/templates/base/http-clients/fetch-http-client.ejs#L159-L224

The return type should be `Promise>` when `unwrapResponseData` is false. If the request is successful and no error is thrown, the error property will always be null.

In fact, it seems like there is no point in having the generic `E` as a part of custom fetch because there is no guarantee that it will be the type given this line https://github.com/acacode/swagger-typescript-api/blob/master/templates/base/http-clients/fetch-http-client.ejs#L206.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.