abs-tudelft / abs-tudelft/tydi

Transferring empty outer lists at lower complexities

未关闭
#224 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
🐬 specification
主要语言
Rust
星标
15
派生
5
PR 合并指标
30 天内没有已合并 PR

描述

## Background

https://abs-tudelft.github.io/tydi/specification/physical.html#last-signal-description

> [C<4] It is illegal to assert a `last` bit for dimension j without also asserting the `last` bits for dimensions j′
> [C<4] It is illegal to assert the last bit for dimension 0 when the respective data lane is inactive, except for empty sequences.

The first rule suggests that at C<4, and (as an example) D=3, it is not possible to assert `last="100"` or `last="110"`, or `last="010"`).

## Issue

This means that at C<4, it is illegal to transfer empty outer lists, which in turn means that Stream complexity has an effect on the _kinds of data_ transferred.

For instance, the example given in the last signal description for C≥8, D=2
`["Hello", "World"], ["Tydi", "is", "nice"], [""], []`
makes use of an empty outer list (the last element, `[]`). This requires asserting `last="10"`.

## Suggested Fix

It is not clear whether this is intentional. However, I am of the opinion that Stream properties should not affect the kind of data which can be transferred.

As such, I recommend amending the first rule in the Background section of this issue to also include an exception for empty sequences.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Review the Tydi specification document linked in the issue, focusing on the physical layer and last signal rules. Examine the codebase for implementations of stream complexity handling and last bit assertions. Look for test cases involving empty outer lists and varying complexities to understand current behavior. Determine where rule amendments would be applied in the specification or code.

由索引模型根据 Issue 内容生成。

评估

技术栈
rust
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。