abrignoni / abrignoni/iLEAPP

Bug: get_data_list_with_media crashes on invalid media IDs

Abierto
#1,237 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
Python
Estrellas
1.2k
Forks
303
Merge medio
4 h 32 min
PR fusionados (30 d)
216

Descripción

get_data_list_with_media in ilapfuncs.py crashes with a TypeError if a module passes it an invalid media ID.

The function currently assumes any value in a media column is a valid reference from check_in_media. If a module developer makes a mistake and leaves a raw string (like a filename or an ID from a source DB) in that column (or puts an invalid value of any kind), the LAVA database lookup returns None, causing the crash.

The function needs to be more defensive. It should check the result of the lava_get_full_media_info() call. If the result is None, it should log the invalid ID it was trying to look up to console and then empty the field to prevent downstream issues. (i.e. don't pass on invalid data for LAVA to deal with.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.