abrignoni / abrignoni/iLEAPP

Bug: get_data_list_with_media crashes on invalid media IDs

Open
#1,237 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
1.2k
Forks
303
Avg merge
4h 32m
Merged PRs (30d)
216

Description

get_data_list_with_media in ilapfuncs.py crashes with a TypeError if a module passes it an invalid media ID.

The function currently assumes any value in a media column is a valid reference from check_in_media. If a module developer makes a mistake and leaves a raw string (like a filename or an ID from a source DB) in that column (or puts an invalid value of any kind), the LAVA database lookup returns None, causing the crash.

The function needs to be more defensive. It should check the result of the lava_get_full_media_info() call. If the result is None, it should log the invalid ID it was trying to look up to console and then empty the field to prevent downstream issues. (i.e. don't pass on invalid data for LAVA to deal with.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.