bug: html formats cancelled out with media column
- Ngôn ngữ chính
- Python
- Star
- 1.2k
- Fork
- 303
- Merge trung bình
- 4 giờ 32 phút
- Pull request đã merge (30 ngày)
- 216
Mô tả
https://github.com/abrignoni/iLEAPP/blob/92e095f60eec073203f16b1586ddf5825a59b0d1/scripts/ilapfuncs.py#L339-L354C49
theres a bug where if you include a media column as part of a data set, it will wipe out any html injected formatting.
line 341 splits the data set tuples into plain and html. then we check for media types on line 352. if so, then line 354 splits a new data set pair but it uses the `data_list` object from a few lines up that has been replaced with plain text during the earlier split.
my suggestion is we do this media detection inside the html output if block. the html output has some limitations and restrictions and needs some of this formatting and prep work to display things well. then inside the html output if block, we can use just the html data set since we fill that value above regardless of injected html tags or not.
lava does not need the style information so we can ignore that from the media column header. lava has its own style rules to apply.
see PR https://github.com/abrignoni/iLEAPP/pull/1139 for references
Hướng dẫn đóng góp
Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này
Đánh giá
Issue này chưa được đánh giá.