abrignoni / abrignoni/iLEAPP

bug: html formats cancelled out with media column

オープン
#1,202 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
bug
主要言語
Python
スター
1.2k
フォーク
303
平均マージ
4時間 32分
マージ済み PR(30日)
216

説明

https://github.com/abrignoni/iLEAPP/blob/92e095f60eec073203f16b1586ddf5825a59b0d1/scripts/ilapfuncs.py#L339-L354C49

theres a bug where if you include a media column as part of a data set, it will wipe out any html injected formatting.

line 341 splits the data set tuples into plain and html. then we check for media types on line 352. if so, then line 354 splits a new data set pair but it uses the `data_list` object from a few lines up that has been replaced with plain text during the earlier split.

my suggestion is we do this media detection inside the html output if block. the html output has some limitations and restrictions and needs some of this formatting and prep work to display things well. then inside the html output if block, we can use just the html data set since we fill that value above regardless of injected html tags or not.

lava does not need the style information so we can ignore that from the media column header. lava has its own style rules to apply.

see PR https://github.com/abrignoni/iLEAPP/pull/1139 for references

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。