aboutcode-org / aboutcode-org/vulnerablecode

Improve Improvers

Aperta
#701 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
core enhancement
Lingua principale
Python
Stelle
702
Fork
328
Merge medio
3g 8h
PR unite (30g)
3

Descrizione

Improvers are constraining.

For eg: Improving reference id to reference URL, improving vuln data (not an advisory).
The problem is with both ``interesting_advisories`` and ``get_inferences`` where both of them expect ``AdvisoryData``.
Improvers cloud be split in
- A condition which checks if this improver runs or not
- then a handling thing.

TOCTOU conditions are also present, we check at ``interesting_advisories`` and use the value at ``get_inferences``. Could do https://docs.djangoproject.com/en/4.0/ref/models/querysets/#select-for-update to avoid TOCTOU closer where things are going to change. This would mean returning a QuerySet from ``interesting_advisories`` might not be an ideal case.

Current implementation could become a subclass which is a advisory based improver.

_(via: https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-tuesday-2022-04-19-at-1000-utc)_

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.