aboutcode-org / aboutcode-org/vulnerablecode

Improve Improvers

Abierto
#701 2 comentarios 0 reacciones 0 asignados Ver en GitHub
core enhancement
Lenguaje dominante
Python
Estrellas
702
Forks
328
Merge medio
3 d 8 h
PR fusionados (30 d)
3

Descripción

Improvers are constraining.

For eg: Improving reference id to reference URL, improving vuln data (not an advisory).
The problem is with both ``interesting_advisories`` and ``get_inferences`` where both of them expect ``AdvisoryData``.
Improvers cloud be split in
- A condition which checks if this improver runs or not
- then a handling thing.

TOCTOU conditions are also present, we check at ``interesting_advisories`` and use the value at ``get_inferences``. Could do https://docs.djangoproject.com/en/4.0/ref/models/querysets/#select-for-update to avoid TOCTOU closer where things are going to change. This would mean returning a QuerySet from ``interesting_advisories`` might not be an ideal case.

Current implementation could become a subclass which is a advisory based improver.

_(via: https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-tuesday-2022-04-19-at-1000-utc)_

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.