aboutcode-org / aboutcode-org/vulnerablecode

Improve Improvers

Open
#701 2 comments 0 reactions 0 assignees View on GitHub
core enhancement
Dominant language
Python
Stars
702
Forks
328
Avg merge
3d 8h
Merged PRs (30d)
3

Description

Improvers are constraining.

For eg: Improving reference id to reference URL, improving vuln data (not an advisory).
The problem is with both ``interesting_advisories`` and ``get_inferences`` where both of them expect ``AdvisoryData``.
Improvers cloud be split in
- A condition which checks if this improver runs or not
- then a handling thing.

TOCTOU conditions are also present, we check at ``interesting_advisories`` and use the value at ``get_inferences``. Could do https://docs.djangoproject.com/en/4.0/ref/models/querysets/#select-for-update to avoid TOCTOU closer where things are going to change. This would mean returning a QuerySet from ``interesting_advisories`` might not be an ideal case.

Current implementation could become a subclass which is a advisory based improver.

_(via: https://github.com/nexB/vulnerablecode/wiki/WeeklyMeetings#meeting-on-tuesday-2022-04-19-at-1000-utc)_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.