aboutcode-org / aboutcode-org/nuget-inspector

NullReferenceException when getting remote metadata

Đang mở
#78 0 bình luận 1 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
C#
Star
5
Fork
13
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

We are using nuget-inspector (orchestrated by ORT) in version 0.10.0 to analyze a project that declares a private source repository. The tool is invoked as follows:

```
nuget-inspector --with-details --verbose --project-file Project.csproj --json /tmp/nuget-inspector-output.json
```
The invocation is successful, but for some packages no metadata can be retrieved, and warnings like the one below are issued for those packages:

```
WARNING: Failed to get remote metadata for name: 'Newtonsoft.Json' version: '13.0.4'. System.NullReferenceException: Object reference not set to an instance of an object.
at NugetInspector.NugetApi.GetPackageDownload(PackageIdentity identity, Boolean with_details) in ./nuget-inspector/NugetApi.cs:line 542
at NugetInspector.BasePackage.UpdateWithRemoteMetadata(NugetApi nugetApi, Boolean with_details) in ./nuget-inspector/Models.cs:line 349
at NugetInspector.BasePackage.Update(NugetApi nugetApi, Boolean with_details) in ./nuget-inspector/Models.cs:line 321
```
According to my analysis, the problem seems to be that the private repository (hosted on JFrog Artifactory) does not return a value for the optional `CatalogUri` property. The code that raises the exception, method `GetPackageDownload()` in `NugetApi.cs` in line 542, accesses this property without a null check:

```
PackageSearchMetadataRegistration? registration = FindPackageVersion(identity);
if (registration == null)
return download;

var package_catalog_url = registration.CatalogUri.ToString(); // <-- Line 542, NRE here
```

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.