aboutcode-org / aboutcode-org/nuget-inspector

NullReferenceException when getting remote metadata

Open
#78 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
5
Forks
13
PR merge metrics
No merged PRs in 30d

Description

We are using nuget-inspector (orchestrated by ORT) in version 0.10.0 to analyze a project that declares a private source repository. The tool is invoked as follows:

```
nuget-inspector --with-details --verbose --project-file Project.csproj --json /tmp/nuget-inspector-output.json
```
The invocation is successful, but for some packages no metadata can be retrieved, and warnings like the one below are issued for those packages:

```
WARNING: Failed to get remote metadata for name: 'Newtonsoft.Json' version: '13.0.4'. System.NullReferenceException: Object reference not set to an instance of an object.
at NugetInspector.NugetApi.GetPackageDownload(PackageIdentity identity, Boolean with_details) in ./nuget-inspector/NugetApi.cs:line 542
at NugetInspector.BasePackage.UpdateWithRemoteMetadata(NugetApi nugetApi, Boolean with_details) in ./nuget-inspector/Models.cs:line 349
at NugetInspector.BasePackage.Update(NugetApi nugetApi, Boolean with_details) in ./nuget-inspector/Models.cs:line 321
```
According to my analysis, the problem seems to be that the private repository (hosted on JFrog Artifactory) does not return a value for the optional `CatalogUri` property. The code that raises the exception, method `GetPackageDownload()` in `NugetApi.cs` in line 542, accesses this property without a null check:

```
PackageSearchMetadataRegistration? registration = FindPackageVersion(identity);
if (registration == null)
return download;

var package_catalog_url = registration.CatalogUri.ToString(); // <-- Line 542, NRE here
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.