abiosoft / abiosoft/ishell

Extraneous space for multiline args

Ouverte
#132 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Go
Étoiles
1.8k
Forks
213
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

First and foremost, thanks for this project! I've been using it successfully in my [AWS Parameter Store shell project](https://github.com/bwhaley/ssmsh).

I've noticed that an extraneous space is added in values with new lines. Here's a reproducible example:

```
package main

import (
"github.com/abiosoft/ishell"
)

func main() {
shell := ishell.New()
shell.AddCmd(&ishell.Cmd{
Name: "test",
Func: func(c *ishell.Context) {
shell.Printf("Got: '%x'\n", c.Args[0])
},
})
shell.Run()
}
```

```
>>> test "foo\
... bar"
Got: '666f6f200a626172'
```

In the hex output we see:
```
666f6f - foo
200a -
626172 - bar
```

The space here is unexpected. I did start looking through the code here but ran out of time before I figured out where it was happening.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.