abiosoft / abiosoft/ishell

Extraneous space for multiline args

Abierto
#132 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Go
Estrellas
1.8k
Forks
213
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

First and foremost, thanks for this project! I've been using it successfully in my [AWS Parameter Store shell project](https://github.com/bwhaley/ssmsh).

I've noticed that an extraneous space is added in values with new lines. Here's a reproducible example:

```
package main

import (
"github.com/abiosoft/ishell"
)

func main() {
shell := ishell.New()
shell.AddCmd(&ishell.Cmd{
Name: "test",
Func: func(c *ishell.Context) {
shell.Printf("Got: '%x'\n", c.Args[0])
},
})
shell.Run()
}
```

```
>>> test "foo\
... bar"
Got: '666f6f200a626172'
```

In the hex output we see:
```
666f6f - foo
200a -
626172 - bar
```

The space here is unexpected. I did start looking through the code here but ran out of time before I figured out where it was happening.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.