abiosoft / abiosoft/ishell

Extraneous space for multiline args

Open
#132 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.8k
Forks
213
PR merge metrics
No merged PRs in 30d

Description

First and foremost, thanks for this project! I've been using it successfully in my [AWS Parameter Store shell project](https://github.com/bwhaley/ssmsh).

I've noticed that an extraneous space is added in values with new lines. Here's a reproducible example:

```
package main

import (
"github.com/abiosoft/ishell"
)

func main() {
shell := ishell.New()
shell.AddCmd(&ishell.Cmd{
Name: "test",
Func: func(c *ishell.Context) {
shell.Printf("Got: '%x'\n", c.Args[0])
},
})
shell.Run()
}
```

```
>>> test "foo\
... bar"
Got: '666f6f200a626172'
```

In the hex output we see:
```
666f6f - foo
200a -
626172 - bar
```

The space here is unexpected. I did start looking through the code here but ran out of time before I figured out where it was happening.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.