abcxyz / abcxyz/guardian

FR: Support merge-check delta on PR history GUARDIAN_DIRS

オープン
#519 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
enhancement
主要言語
Go
スター
26
フォーク
7
平均マージ
1日 1時間
マージ済み PR(30日)
1

説明

### TL;DR

Current merge-check does not check the history of all PRs and whether entrypoints were force planned/applied via GUARDIAN_DIRS. If a PR in the history (and not in the feature branch history) was force applied this way then we should force the author to rebase too.

### Detailed design

We will need to update [tagrep](https://github.com/abcxyz/tagrep) to fetch the history of all PRs in the git log that are not in the feature branch.

One possible solution is to make tagrep be able to handle an array of target PRs (by commit hash in this case) and introduce a strategy for merging the results from these PRs. In this case we just want a concatenated list of the unique GUARDIAN_DIRS from all PRs in the list.

### Alternatives considered

1. Ignore it. Its a low risk
2. Don't use PR descriptions to trigger plan/applys. Force users to edit files

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

The issue requires modifying the tagrep tool to process an array of target PRs from git history and merge their GUARDIAN_DIRS entries. Start by examining the tagrep repository to understand its current interface and data structures. Look at how guardian currently calls tagrep for merge-checks. Determine how to fetch the git log for PRs not in the feature branch and design a strategy to concatenate unique GUARDIAN_DIRS. Testing will involve simulating PR histories with force-applied entries.

索引モデルが issue の本文から書いたものです。

評価

領域
devops, tooling
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。