aalhour / aalhour/C-Sharp-Algorithms

IsAnagram bug (per element counts)

未关闭 适合新手
#153 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C#
星标
6.2k
派生
1.4k
PR 合并指标
30 天内没有已合并 PR

描述

### Describe the bug
The `IsAnagram` function is not checking per-element counts. It is only checking if they have the same elements, but not if the count of each element matches.

A more appropriate name for the current logic is something like `ContainsNoDifferingElements` or `IntersectsMatch` rather than `IsAnagram`. I would recommend changing the name or the logic of the method.

> Note: If you aren't going to check per-element counts, then you should also get rid of this check in `IsAnagrams`:
> ```cs
> if (source.Length != other.Length)
> return false;
> ```
> because length doesn't matter if you don't also check per-element counts.

### To Reproduce
Add the following case to the `IsAnagram` unit tests:
```cs
string aab = "aab";
string abb = "abb";
Assert.False(Permutations.IsAnargram(aab, abb));
```

### Expected behavior
Spans of the same length and elements but different per-element counts should not be considered re-orders/anagrams of each other.

### Environment:
_master branch_

### Additional context
I have written my own version of this algorithm in C# _(that fixes this issue)_ if interested here...
> Source Code: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Sources/Towel/Statics-SequenceAnalysis.cs#L1321
> Examples: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Examples/BasicsAndExtensions/Program.cs#L406
> Testing: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Tools/Towel_Testing/Statics.cs#L2086
> _Note: `MapHashLinked` is my version of a `Dictionary` if you look at the source code._

贡献指南

打开贡献指南

调研方向

问题出在 Permutations.IsAnagram 方法中。查看单元测试以了解当前行为。该错误在于它没有检查每个元素的数量。修复方案是更新算法,统计每个字符的出现次数。提供的外部链接展示了一个修正后的实现。先添加失败的测试用例,然后修改该方法使其通过测试。

由索引模型根据 Issue 内容生成。

评估

领域
testing-qa
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
70/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。