aalhour / aalhour/C-Sharp-Algorithms
IsAnagram bug (per element counts)
- Linguagem predominante
- C#
- Estrelas
- 6.2k
- Forks
- 1.4k
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
### Describe the bug
The `IsAnagram` function is not checking per-element counts. It is only checking if they have the same elements, but not if the count of each element matches.
A more appropriate name for the current logic is something like `ContainsNoDifferingElements` or `IntersectsMatch` rather than `IsAnagram`. I would recommend changing the name or the logic of the method.
> Note: If you aren't going to check per-element counts, then you should also get rid of this check in `IsAnagrams`:
> ```cs
> if (source.Length != other.Length)
> return false;
> ```
> because length doesn't matter if you don't also check per-element counts.
### To Reproduce
Add the following case to the `IsAnagram` unit tests:
```cs
string aab = "aab";
string abb = "abb";
Assert.False(Permutations.IsAnargram(aab, abb));
```
### Expected behavior
Spans of the same length and elements but different per-element counts should not be considered re-orders/anagrams of each other.
### Environment:
_master branch_
### Additional context
I have written my own version of this algorithm in C# _(that fixes this issue)_ if interested here...
> Source Code: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Sources/Towel/Statics-SequenceAnalysis.cs#L1321
> Examples: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Examples/BasicsAndExtensions/Program.cs#L406
> Testing: https://github.com/ZacharyPatten/Towel/blob/d2660e208ad3a44ab22f192834760c5b93dc82ac/Tools/Towel_Testing/Statics.cs#L2086
> _Note: `MapHashLinked` is my version of a `Dictionary` if you look at the source code._
Guia de contribuição
Direção de pesquisa
O problema está no método Permutations.IsAnagram. Consulte os testes unitários para entender o comportamento atual. O bug é que ele não verifica as contagens por elemento. A correção envolve atualizar o algoritmo para contar as ocorrências de cada caractere. O link externo fornecido mostra uma implementação corrigida. Adicione primeiro o caso de teste que falha e, em seguida, modifique o método para fazê-lo passar.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Domínio
- testing-qa
- Tipo de issue
- Bug
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 70/100