aachman98 / aachman98/Sorcar

[BUG] Merge Objects wouldn't merge two NodeGroups

Open
#139 13 comments 0 reactions 0 assignees View on GitHub
enhancement scheduled ux
Dominant language
Python
Stars
1.2k
Forks
112
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**

Merge Objects won't merge two NodeGroups properly on be1b1d4.

**To Reproduce**
1. Create the following graph named `MakeBox`:
![image](https://user-images.githubusercontent.com/693/83357639-777e1f00-a365-11ea-950f-76358764cd0c.png)
2. Create the following graph named `DuplicateByDistance`:
![image](https://user-images.githubusercontent.com/693/83357673-aac0ae00-a365-11ea-88f5-2ffc52475cdb.png)

**Expected behavior**
Merging Objects from these two NodeGroups should produce an object

3. Observe node groups working in isolation in the main graph:
![image](https://user-images.githubusercontent.com/693/83357707-dfcd0080-a365-11ea-9afe-a1489c7557e8.png)
produces
![image](https://user-images.githubusercontent.com/693/83357711-e3f91e00-a365-11ea-9f1e-c59b187b6af7.png)
and
![image](https://user-images.githubusercontent.com/693/83357714-ec515900-a365-11ea-958f-4b3a69f82222.png)
produces
![image](https://user-images.githubusercontent.com/693/83357718-f96e4800-a365-11ea-9da6-df0a992ddc39.png)

4. However, joining them two
![image](https://user-images.githubusercontent.com/693/83357748-26baf600-a366-11ea-8f90-543bccd441d4.png)
still produces only
![image](https://user-images.githubusercontent.com/693/83357718-f96e4800-a365-11ea-9da6-df0a992ddc39.png)

additionally, the first node group outputs `Box: -` making it look like the box wasn't evaluated.

**Screenshots**
Screenshots provided above

**Desktop (please complete the following information):**
- OS: OSX
- Blender Version: 2.82
- Sorcar Version: be1b1d4

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue is about the Merge Objects node failing to merge two NodeGroups in Sorcar, a Blender addon for procedural modeling. Look at the node graph logic in the Sorcar codebase, particularly the merge operation implementation. The screenshots show the expected vs actual behavior; start by reproducing the bug with the provided graphs. Check the NodeGroup evaluation and the Merge Objects node's handling of multiple inputs. The last comment is from 2294 days ago, so the codebase may have changed significantly.

Written by the indexing model from the issue text.

Assessment

Tech stack
blender, python
Domain
computer-graphics, game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.