a8m / a8m/angular-filter

Inconsistent return value for shortFmt

未關閉
#205 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
2.9k
分支
319
PR 合併指標
30 天內沒有已合併 PR

描述

### The current behavior

When given an Number less than 1000, shortFmt returns a Number. Otherwise, it returns a String.
### Why is this a problem?

Consider the following case:

```
{{ (n | shortFmt:1) || 'N/A'}}
```

When `n = 0`, this will print "N/A" (Why? Because 0 is a false-y value in JS. Therefore, it evaluates the right-hand side of the "||"). I believe that most developers would expect this to print "0" instead. (Similar to the behavior of angular's `number` filter)
### Proposed fix

When `n < 1000`, return `n + ''`. This will coerce the Number into a String.

If this seems like a reasonable behavior, then I'll go ahead and create a PR for this later today.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。