a8m / a8m/angular-filter

Inconsistent return value for shortFmt

未关闭
#205 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
2.9k
派生
319
PR 合并指标
30 天内没有已合并 PR

描述

### The current behavior

When given an Number less than 1000, shortFmt returns a Number. Otherwise, it returns a String.
### Why is this a problem?

Consider the following case:

```
{{ (n | shortFmt:1) || 'N/A'}}
```

When `n = 0`, this will print "N/A" (Why? Because 0 is a false-y value in JS. Therefore, it evaluates the right-hand side of the "||"). I believe that most developers would expect this to print "0" instead. (Similar to the behavior of angular's `number` filter)
### Proposed fix

When `n < 1000`, return `n + ''`. This will coerce the Number into a String.

If this seems like a reasonable behavior, then I'll go ahead and create a PR for this later today.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。